-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Places renders
object in Item properties
#5
Places renders
object in Item properties
#5
Conversation
render
object in Item propertiesrenders
object in Item properties
a08232c
to
da0e40f
Compare
seems good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please just add your changes in the CHANGELOG
Thanks @emmanuelmathot, I just updated the changelog. |
da0e40f
to
e5f9ee6
Compare
We will prepare a PR for the v2 release. |
Hey, @emmanuelmathot! I'm working on implementing the Render extension in |
I have a second thought on this one. Initially, we put |
Hi @emmanuelmathot, I don't have strong opinions about it, but I'd mention that I proposed this change back then because I was unable to store the But if that changes, I don't see any other blocker - from my limited knowledge - unless other tools may need to be adapted to accept item-level custom fields. |
Thanks for the quick response @emmanuelmathot and additional context @giorgiobasile! Are there any other extension specifications that place additional metadata at the top-level on Items? I spot-checked specs and didn't find any. While the Item spec does not restrict additional top-level fields, it looks like the recommended convention of placing additional metadata within Item FWIW |
I am not aware of other extension using top level fields. I think the best is probably to go forward with this change. |
Changes the JSON Schema, updates examples and docs.
Closes #4